Narrow by constant element access callees#62314
Open
Andarist wants to merge 1 commit intomicrosoft:mainfrom
Open
Narrow by constant element access callees#62314Andarist wants to merge 1 commit intomicrosoft:mainfrom
Andarist wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for narrowing by type predicates when using element access expressions with constant arguments, addressing issue #62247. The fix allows TypeScript to properly narrow types when calling type predicate methods through computed property access with symbol keys.
Key Changes:
- Enhanced type narrowing logic to support element access expressions with constant arguments in addition to property access expressions
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/compiler/checker.ts |
Updated type narrowing condition to include element access expressions with constant arguments |
src/compiler/binder.ts |
Extended narrowable reference detection to support element access expressions |
tests/cases/compiler/narrowByTypePredicateFromElementAccessExpression1.ts |
Added test case demonstrating type narrowing with symbol-based element access |
tests/baselines/reference/narrowByTypePredicateFromElementAccessExpression1.types |
Generated baseline showing expected type information |
tests/baselines/reference/narrowByTypePredicateFromElementAccessExpression1.symbols |
Generated baseline showing expected symbol resolution |
Comments suppressed due to low confidence (1)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #62247